Skip to content

move define_atomic_id to bevy_utils #22417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 2 commits into from
Jan 8, 2026
Merged

move define_atomic_id to bevy_utils #22417

alice-i-cecile merged 2 commits into from
Jan 8, 2026
+17 −34

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 7, 2026 •
edited
Loading

Objective

  • when i made bevy_shader, i inlined the define_atomic_id macro because i wasnt sure if one usage was enough justification for kicking it into utils
  • bevy_material needs this in several places too, so let's kick it out in preparation. 3 usages outside bevy_render is enough justification its not actually needed for bevy_material

Solution

  • move file

Testing

  • examples, clippy etc.

@atlv24 atlv24 added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 7, 2026
@kfc35 kfc35 added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jan 8, 2026
kfc35
kfc35 approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me

@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Jan 8, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 8, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 8, 2026
Merged via the queue into bevyengine:main with commit 7a436e3 Jan 8, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atlv24 @kfc35 @alice-i-cecile