Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Added helpful adders for systemsets #2366

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Added helpful adders for systemsets #2366

wants to merge 2 commits into from

Conversation

CGMossa
Copy link
Contributor

@CGMossa CGMossa commented Jun 20, 2021

Objective

  • This adds a way to add SystemSets to Apps.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jun 20, 2021
@CGMossa @bjorn3
Update crates/bevy_app/src/app_builder.rs
13b0cdb 
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
@NathanSWard NathanSWard added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Jun 20, 2021
@alice-i-cecile
Copy link
Member

I still think we should move to a better builder API for this sort of thing, but this is necessary until then.

NathanSWard
NathanSWard approved these changes Jun 20, 2021
View reviewed changes
Copy link
Contributor

@NathanSWard NathanSWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should move to a better builder API for this sort of thing, but this is necessary until then.

Yep agreed.

@NathanSWard NathanSWard added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 20, 2021
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 23, 2021
@CGMossa
Added helpful adders for systemsets (#2366)
3106dc4 
# Objective

- This adds a way to add `SystemSet`s to Apps.
@bors
Copy link
Contributor

bors bot commented Jun 23, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added helpful adders for systemsets [Merged by Bors] - Added helpful adders for systemsets Jun 23, 2021
@bors bors bot closed this Jun 23, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@CGMossa @ostwilkens
Added helpful adders for systemsets (bevyengine#2366)
40f5592 
# Objective

- This adds a way to add `SystemSet`s to Apps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@lafi-99 lafi-99 lafi-99 approved these changes

@NathanSWard NathanSWard NathanSWard approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CGMossa @alice-i-cecile @mockersf @bjorn3 @NathanSWard @lafi-99