Fix in rendering resources node for despawning #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested this with my project that was previously crashing when using despawn and this does fix the issue. Thanks! |
|
It works great in my code. It works great |
karroffel
added
C-Bug
|
This PR currently only fixes panic during rendering related to a reduction in the number of render components ( through despawning or is_visible=false) followed by addition of new renderable components. |
|
Hopefully this will be merged soon. Really important fix in my opinion 😄 |
|
This works for me too. We'll need to sort out a better long term solution, but this is 100% "worth it" at this point. Thanks! |
BimDav
pushed a commit
to BimDav/bevy
that referenced
this pull request
Aug 26, 2020
…nces as get_or_assign_index will now always assign (bevyengine#247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #135 .
This fix has the drawback to reset the stored indices each frame, so the get_or_assign_index function will always assign.
But the underlying issue is in the incoherency between the changed_item_count which evolves with new/dead/drawn/invisible rendering components, while the indices were created once and for all.
Impact on spawner.rs example seems in the 0.3%.
I have not added the changes to fix the rendering issue with Draw.is_visible=false, as I have already done a PR for that (#230)