Allowing the wgpu renderer to be created externally #2743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
| .insert_resource(queue.clone()) | ||
| let renderer = app | ||
| .world | ||
| .remove_resource::<renderer::Renderer>() |
There was a problem hiding this comment.
This is to remove the Renderer resource if it exists right?
I would prefer an explicit check / branch over a removal here.
There was a problem hiding this comment.
It'll create ownership problems if we leave renderer::Renderer in App. Specifically, RenderInstance is not Clone. So, you can have RenderInstance in the app or the render subapp, but not both.
Neo-Zhixing
force-pushed
the
pipelined-rendering
branch
from
9333cae to
df3f793
Compare
Neo-Zhixing
force-pushed
the
pipelined-rendering
branch
from
df3f793 to
7df77dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR makes it so that bevy_render2 will create the WGPU Renderer if and only if there isn't already one created. The motivation in my case is that this would allow me to create the WGPU instance from raw handles (gfx-rs/wgpu#1609)
Solution
To create the WGPU Renderer externally, the user needs to create
bevy_render2::renderer::Rendererbefore initializing thebevy_render2plugin and insert it into the world.bevy_render2will try to remove the renderer from the world and use it upon initialization.