Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bevy_ecs compile without the bevy_reflect feature #2842

Closed
wants to merge 1 commit into from
Closed

Make bevy_ecs compile without the bevy_reflect feature #2842

wants to merge 1 commit into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 18, 2021

Objective

  • Make bevy_ecs compile with default-features=false
    • I was trying to be a good citizen with my library, not bringing in unneeded features
    • Not that anyone has used bevy_ecs without the bevy_reflect feature, but there has to be a first 👀

Solution

  • Conditionally compile out the parts which stop compilation.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Sep 18, 2021
@DJMcNab DJMcNab added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Sep 18, 2021
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 18, 2021
@DJMcNab
Copy link
Member Author

DJMcNab commented Nov 10, 2021

Superceded by #3097

@DJMcNab DJMcNab closed this Nov 10, 2021
@mockersf
Copy link
Member

ho sorry I forgot this one was opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJMcNab @mockersf