Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update derive(DynamicPlugin) to edition 2021 #3038

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update derive(DynamicPlugin) to edition 2021 #3038

wants to merge 1 commit into from

Conversation

Iaiao
Copy link
Contributor

@Iaiao Iaiao commented Oct 27, 2021

Objective

Edition 2021 requires dyn Trait and it won't compile without dyn.

Solution

Added dyn.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Oct 27, 2021
DJMcNab
DJMcNab approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm interested to hear about how you're using the dynamic plugin.

In particular, I personally think we should probably remove it at present, since it seems quite difficult to use correctly

However, this is purely a win, so I'm in favour of merging this anyway.

@DJMcNab DJMcNab added C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Oct 27, 2021
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Oct 27, 2021
@Iaiao
Copy link
Contributor Author

Iaiao commented Oct 27, 2021

I'm rewriting some game server software in bevy, and today I started working on dynamic plugins, so I don't really have much experience using them, but seems like it works, and making it work was way easier than I thought.

@cart
Copy link
Member

cart commented Oct 27, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 27, 2021
@Iaiao
Update derive(DynamicPlugin) to edition 2021 (#3038)
91c3b21 
# Objective
Edition 2021 requires `dyn Trait` and it won't compile without `dyn`.

## Solution
Added `dyn`.
@bors
Copy link
Contributor

bors bot commented Oct 27, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update derive(DynamicPlugin) to edition 2021 [Merged by Bors] - Update derive(DynamicPlugin) to edition 2021 Oct 27, 2021
@bors bors bot closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Iaiao @cart @alice-i-cecile @DJMcNab @mockersf