[Merged by Bors] - WebGL2 support #3039

mrk-its · 2021-10-27T21:35:57Z

Objective

Make possible to use wgpu gles backend on in the browser (wasm32 + WebGL2).

Solution

It is built on top of old @cart patch initializing windows before wgpu. Also:

initializes wgpu with Backends::GL and proper wgpu::Limits on wasm32
changes default texture format to wgpu::TextureFormat::Rgba8UnormSrgb

bjorn3 · 2021-10-27T22:04:25Z

crates/bevy_winit/src/lib.rs

@@ -525,3 +529,22 @@ fn handle_create_window_events(
        });
    }
 }
+
+fn handle_initial_window_events(world: &mut World, event_loop: &EventLoop<()>) {


Can you do this in the winit_runner_with and keep the EventLoop argument of winit_runner_with?

@cart ? (it is your code :) But it seems handle_initial_window_events needs to be called as is, because we need to have a window when renderer_plugin is initialized.

Yup sadly its an order of operations thing. We need to init these windows before the RenderPlugin is setup, not before the app starts running.

bjorn3 · 2021-10-27T22:06:24Z

pipelined/bevy_render2/src/texture/mod.rs

@@ -42,7 +42,7 @@ pub trait BevyDefault {

 impl BevyDefault for wgpu::TextureFormat {
    fn bevy_default() -> Self {
-        if cfg!(target_os = "android") {
+        if cfg!(target_os = "android") || cfg!(target_arch = "wasm32") {


Can we use rgba everywhere? Are there any advantages to bgra on other platforms?

I remember hearing that a lot of hardware only supports (or prefers) bgra swap chains.

Wgpu used to use bgra as a default in their examples, but it looks like at some point they switched to rgba. @kvark is there any reason to default to bgra at this point?

At this point we can default to RGBA. Originally, we weren't sure if RGBA is really supported everywhere for presentation, as weird as it sounds.

bjorn3 · 2021-10-27T22:08:59Z

pipelined/bevy_render2/src/lib.rs

+            Backends::PRIMARY
+        } else {
+            Backends::GL
+        };


Wgpu be changed to default to webgl on wasm?

Good point, it would be great to prefer webgpu over webgl if available (probably). I'll try to figure out how to do it.

I don't think its worth blocking on this, but I agree that its a "nice to have".

mockersf · 2021-10-27T22:01:39Z

pipelined/bevy_render2/Cargo.toml

@@ -29,7 +29,7 @@ bevy_utils = { path = "../../crates/bevy_utils", version = "0.5.0" }
 image = { version = "0.23.12", default-features = false }

 # misc
-wgpu = { version = "0.11.0", features = ["spirv"] }
+wgpu = { version = "0.11.0", features = ["spirv", "webgl"] }


Should this feature be enabled only in wasm? That's possible now with edition 2021

probably, taking a look

just fixed this

cart · 2021-10-29T00:19:23Z

Just pushed a change to only enable the wgpu webgl feature on wasm. I think this is good to go. Some follow ups to do:

Default to rgba on all platforms if theres no reason not to
Fix bevy_pbr2 to work on wasm
Make bevy build on wasm without needing to mess with defaults (we should solve this after merging into main + removing the old renderer)
Try defaulting to WebGPU on platforms where it is available

cart · 2021-10-29T00:19:33Z

bors r+

@cart

# Objective Make possible to use wgpu gles backend on in the browser (wasm32 + WebGL2). ## Solution It is built on top of old @cart patch initializing windows before wgpu. Also: - initializes wgpu with `Backends::GL` and proper `wgpu::Limits` on wasm32 - changes default texture format to `wgpu::TextureFormat::Rgba8UnormSrgb` Co-authored-by: Mariusz Kryński <mrk@sed.pl>

cart · 2021-10-29T00:22:31Z

Also I can confirm that bevymark_pipelined does work on wasm/webgl2 if i disable the following features: bevy_audio, bevy_dynamic_plugin, bevy_wgpu, bevy_pbr2, render, mp3

bors · 2021-10-29T00:25:10Z

Build failed:

build (nightly, ubuntu-latest)

cart · 2021-10-29T00:28:44Z

bors r+

@cart

# Objective Make possible to use wgpu gles backend on in the browser (wasm32 + WebGL2). ## Solution It is built on top of old @cart patch initializing windows before wgpu. Also: - initializes wgpu with `Backends::GL` and proper `wgpu::Limits` on wasm32 - changes default texture format to `wgpu::TextureFormat::Rgba8UnormSrgb` Co-authored-by: Mariusz Kryński <mrk@sed.pl>

bors · 2021-10-29T00:35:37Z

Build failed:

build (stable, macos-latest)

mockersf · 2021-10-29T00:38:30Z

crates/bevy_winit/src/lib.rs

-use winit::platform::unix::EventLoopExtUnix;
-


the cfg before should be removed also

bawhaha well that wasn't smart of me

cart · 2021-10-29T00:46:01Z

bors r+

@cart

# Objective Make possible to use wgpu gles backend on in the browser (wasm32 + WebGL2). ## Solution It is built on top of old @cart patch initializing windows before wgpu. Also: - initializes wgpu with `Backends::GL` and proper `wgpu::Limits` on wasm32 - changes default texture format to `wgpu::TextureFormat::Rgba8UnormSrgb` Co-authored-by: Mariusz Kryński <mrk@sed.pl>

bors · 2021-10-29T01:07:41Z

Pull request successfully merged into pipelined-rendering.

Build succeeded:

This reverts commit 7d932ac.

cart and others added 4 commits October 27, 2021 23:04

fix webgl init by initializing windows before wgpu

80175a5

fix wgpu initialization

d852db3

add webgl to wgpu features

9e6eccd

use Rgba8UnormSrgb by default on wasm32

c2b89d3

DJMcNab added A-Rendering Drawing game state to the screen O-Web Specific to web (WASM) builds S-Needs-Review labels Oct 27, 2021

cargo fmt

52f9f4a

bjorn3 reviewed Oct 27, 2021

View reviewed changes

mockersf reviewed Oct 27, 2021

View reviewed changes

only enable webgl feature on wasm targets

6716a28

clippy

20a761c

mockersf added the hacktoberfest-accepted label Oct 29, 2021

mockersf reviewed Oct 29, 2021

View reviewed changes

come on cart get it together!

dbe09fa

bors bot changed the title ~~WebGL2 support~~ [Merged by Bors] - WebGL2 support Oct 29, 2021

bors bot closed this Oct 29, 2021

bjorn3 mentioned this pull request Oct 30, 2021

Pipelined Rendering: bevy does not request surface compatibility from wgpu #3051

Open

HackerFoo mentioned this pull request Nov 26, 2021

Previously working iOS example crashes on touch #3185

Open

HackerFoo added a commit to HackerFoo/bevy that referenced this pull request Nov 26, 2021

Revert "WebGL2 support (bevyengine#3039)"

ae88e2d

This reverts commit 7d932ac.

bjorn3 mentioned this pull request Jan 12, 2022

Get raw window handle only after Resume event #3639

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - WebGL2 support #3039

[Merged by Bors] - WebGL2 support #3039

mrk-its commented Oct 27, 2021 •

edited

Loading

bjorn3 Oct 27, 2021

mrk-its Oct 27, 2021

cart Oct 28, 2021

bjorn3 Oct 27, 2021

cart Oct 28, 2021

cart Oct 28, 2021

kvark Oct 30, 2021

bjorn3 Oct 27, 2021

mrk-its Oct 27, 2021

cart Oct 29, 2021

mockersf Oct 27, 2021

mrk-its Oct 27, 2021

cart Oct 29, 2021

cart commented Oct 29, 2021

cart commented Oct 29, 2021

cart commented Oct 29, 2021 •

edited

Loading

bors bot commented Oct 29, 2021

cart commented Oct 29, 2021

bors bot commented Oct 29, 2021

mockersf Oct 29, 2021

cart Oct 29, 2021

cart commented Oct 29, 2021

bors bot commented Oct 29, 2021

[Merged by Bors] - WebGL2 support #3039

[Merged by Bors] - WebGL2 support #3039

Conversation

mrk-its commented Oct 27, 2021 • edited Loading

Objective

Solution

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cart commented Oct 29, 2021

cart commented Oct 29, 2021

cart commented Oct 29, 2021 • edited Loading

bors bot commented Oct 29, 2021

cart commented Oct 29, 2021

bors bot commented Oct 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cart commented Oct 29, 2021

bors bot commented Oct 29, 2021

mrk-its commented Oct 27, 2021 •

edited

Loading

cart commented Oct 29, 2021 •

edited

Loading