[Merged by Bors] - Assert compiler errors for compile_fail tests #3067
Conversation
NiklasEi
added
A-ECS
NiklasEi
force-pushed
the
assert_compiler_errors_for_compile_fail_tests
branch
from
88e97ef to
6c7be3f
Compare
|
This is super useful and solves a very real problem. I feel so much safer now :) |
NiklasEi
force-pushed
the
assert_compiler_errors_for_compile_fail_tests
branch
from
6c7be3f to
ce8ad19
Compare
|
Nice! It will probably add to the things we need to update on a new rust version, and also fail things like crater builds. Would there be a way to run those kind of tests not on a simple |
|
Maybe if we move them into a seperate crate that is not part of the workspace? |
NiklasEi
force-pushed
the
assert_compiler_errors_for_compile_fail_tests
branch
from
ce8ad19 to
0e05f04
Compare
|
The UI tests are now moved into a separate crate that is not part of the Bevy workspace. They get executed by the |
|
Could you fix the warning in CI It could be confusing in the future in case of other errors |
I added an empty |
|
bors try The redit link is failing to resolve... |
|
Cool I think this is good to go, but I think the |
|
bors r+ |
# Objective bevy_ecs has several compile_fail tests that assert lifetime safety. In the past, these tests have been green for the wrong reasons (see e.g. #2984). This PR makes sure, that they will fail if the compiler error changes. ## Solution Use [trybuild](https://crates.io/crates/trybuild) to assert the compiler errors. The UI tests are in a separate crate that is not part of the Bevy workspace. This is to ensure that they do not break Bevy's crater builds. The tests get executed by the CI workflow on the stable toolchain.
|
Build failed (retrying...): |
# Objective bevy_ecs has several compile_fail tests that assert lifetime safety. In the past, these tests have been green for the wrong reasons (see e.g. #2984). This PR makes sure, that they will fail if the compiler error changes. ## Solution Use [trybuild](https://crates.io/crates/trybuild) to assert the compiler errors. The UI tests are in a separate crate that is not part of the Bevy workspace. This is to ensure that they do not break Bevy's crater builds. The tests get executed by the CI workflow on the stable toolchain.
bors
bot
changed the title
Objective
bevy_ecs has several compile_fail tests that assert lifetime safety. In the past, these tests have been green for the wrong reasons (see e.g. #2984). This PR makes sure, that they will fail if the compiler error changes.
Solution
Use trybuild to assert the compiler errors.
The UI tests are in a separate crate that is not part of the Bevy workspace. This is to ensure that they do not break Bevy's crater builds. The tests get executed by the CI workflow on the stable toolchain.