Fix bevy_ecs README.md #3279
Closed
Fix bevy_ecs README.md #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Dec 8, 2021
| @@ -131,7 +131,7 @@ fn main() { | |||
| // Add a Stage to our schedule. Each Stage in a schedule runs all of its systems | |||
| // before moving on to the next Stage | |||
| schedule.add_stage("update", SystemStage::parallel() | |||
| .with_system(movement) | |||
| .with_system(movement.system()) | |||
| @@ -109,7 +109,7 @@ struct Position { | |||
| } | |||
|
|
|||
| // This system moves each entity with a Position and Velocity component | |||
| fn movement(query: Query<(&mut Position, &Velocity)>) { | |||
| fn movement(mut query: Query<(&mut Position, &Velocity)>) { | |||
There was a problem hiding this comment.
This is correct; good catch.
| @@ -131,7 +131,7 @@ fn main() { | |||
| // Add a Stage to our schedule. Each Stage in a schedule runs all of its systems | |||
| // before moving on to the next Stage | |||
| schedule.add_stage("update", SystemStage::parallel() | |||
| .with_system(movement) | |||
| .with_system(movement.system()) | |||
There was a problem hiding this comment.
No longer needed on main, see #2398
alice-i-cecile
added
A-ECS
|
Yup adding |
|
Ah, I see, and as I'm using bevy_ecs 0.5, the patch from june is not live yet, gotcha. Will amend to just show the mut then. |
|
Indeed, although that fix is already in #2575 |
|
@DJMcNab indeed, closing it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
system()needs to be called.