Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix crash with disabled winit #3330

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix crash with disabled winit #3330

wants to merge 1 commit into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Dec 15, 2021

Objective

This PR fixes a crash when winit is enabled when there is a camera in the world. Part of #3155

Solution

In this PR, I removed two unwraps and added an example for regression testing.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 15, 2021
@cart
Copy link
Member

cart commented Dec 15, 2021

Looks good to me!

@cart
Copy link
Member

cart commented Dec 15, 2021

you will need to add the new example to the examples/README.md file to pass CI.

@Shatur Shatur changed the title Fix crash with disable winit Fix crash with disabled winit Dec 15, 2021
@cart
Copy link
Member

cart commented Dec 15, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 15, 2021
# Objective

This PR fixes a crash when winit is enabled when there is a camera in the world. Part of #3155

## Solution

In this PR, I removed two unwraps and added an example for regression testing.
@bors bors bot changed the title Fix crash with disabled winit [Merged by Bors] - Fix crash with disabled winit Dec 15, 2021
@bors bors bot closed this Dec 15, 2021
@Shatur Shatur deleted the disable-winit branch December 15, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs-Triage This issue needs to be labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants