Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Enable trace feature for subfeatures using it #3337

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Enable trace feature for subfeatures using it #3337

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • It isn't very useful to be able to enable feature trace_chrome on its own

Solution

  • Enable trace feature when enabling trace_chrome or trace_tracy

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 15, 2021
DJMcNab
DJMcNab approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Is it worth also dealing with the fact that the trace features have different names depending on which crate they're in?

I.e. trace_chrome in bevy, but tracing-chrome in bevy_log

@mockersf
Copy link
Member Author

In bevy_log, they are named like that for the name of the crates that are optional using the "auto feature for optional crates" thingy in cargo. I don't think it's worth it to add a feature that would just enable a crate.

@mockersf mockersf added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Log and removed S-Needs-Triage This issue needs to be labelled labels Dec 15, 2021
@DJMcNab
Copy link
Member

DJMcNab commented Dec 15, 2021

But perhaps we should go the other way, and name the features in the parent crates after the crates they activate?

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Dec 15, 2021
@cart
Copy link
Member

cart commented Dec 18, 2021

I personally like the consistency of trace_X for whatever X backend we choose to use / how that pairs with the trace feature name.

@cart
Copy link
Member

cart commented Dec 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 18, 2021
@mockersf
Enable trace feature for subfeatures using it (#3337)
3974e02 
# Objective

- It isn't very useful to be able to enable feature `trace_chrome` on its own

## Solution

- Enable `trace` feature when enabling `trace_chrome` or `trace_tracy`


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 18, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable trace feature for subfeatures using it [Merged by Bors] - Enable trace feature for subfeatures using it Dec 18, 2021
@bors bors bot closed this Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @DJMcNab @cart @alice-i-cecile