[Merged by Bors] - Improved bevymark: no bouncing offscreen and spawn waves from CLI #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
C-Examples
bjorn3
reviewed
Dec 17, 2021
alice-i-cecile
added
the
C-Code-Quality
alice-i-cecile
approved these changes
Dec 17, 2021
mockersf
force-pushed
the
improved-bevymark
branch
from
b82543a
to
d282b86
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 18, 2021
) # Objective - In bevymark, bevies were very bouncy and could go off screen after a while, skewing the FPS https://user-images.githubusercontent.com/8672791/146540848-282fa11b-d058-4da9-8e95-688ae67d9406.mp4 ## Solution - Make bevies bounce also on top of the screen - I also changed how the examples read args from CLI to be able to spawn waves: `cargo run --example bevymark --release -- 5 100` (first is number of bevy per wave, second is number of wave, with one wave every 0.2 seconds). This makes it easier to reproduce some exact situations https://user-images.githubusercontent.com/8672791/146542857-2f953fa0-7b8d-4772-93f8-b8d7a31259dc.mp4 Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bouncy-bevymark.mp4
Solution
cargo run --example bevymark --release -- 5 100(first is number of bevy per wave, second is number of wave, with one wave every 0.2 seconds). This makes it easier to reproduce some exact situationswaved-bevymark.mp4