Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SceneSpawner: add unload() and unload_sync() #339

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

Fishrock123
Copy link
Contributor

This allows you to unload scenes.

Refs: #255

I've been struggling to get an example up that isn't just rewriting the breakout game to use scenes, maybe someone can help me make something simpler to properly verify this.

@karroffel karroffel added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible labels Aug 25, 2020
crates/bevy_scene/src/scene_spawner.rs Outdated Show resolved Hide resolved
crates/bevy_scene/src/scene_spawner.rs Outdated Show resolved Hide resolved
crates/bevy_scene/src/scene_spawner.rs Outdated Show resolved Hide resolved
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A lot of people want this feature 😄

Just a couple of small changes needed. I'd say its fine to not add an example in this pr. Its worth spending some time to come up with an interesting spawn / despawn example.

crates/bevy_scene/src/scene_spawner.rs Outdated Show resolved Hide resolved
crates/bevy_scene/src/scene_spawner.rs Outdated Show resolved Hide resolved
This allows you to unload scenes.

Refs: bevyengine#255
@Fishrock123
Copy link
Contributor Author

@cart Addressed and updated.

@cart cart merged commit 54e9f44 into bevyengine:master Sep 6, 2020
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants