Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Feature for bevy UI #3546

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Feature for bevy UI #3546

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 4, 2022

Objective

  • For a plugin, I would like to enable bevy_ui without adding the complete render feature

Solution

  • Add a feature for bevy_ui

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 4, 2022
@mockersf mockersf force-pushed the feature-for-bevy_ui branch from d5dff98 to b404453 Compare January 4, 2022 11:50
Davier
Davier approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@Davier Davier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple and uncontroversial to me. I tested it with bevy = {path = "../bevy/", default_features = false, features = ["bevy_ui"]}.

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Jan 4, 2022
alice-i-cecile
alice-i-cecile approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've wanted this for my own input mapping library, and this should be an uncontroversial split.

Changes LGTM.

@cart
Copy link
Member

cart commented Jan 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 4, 2022
@mockersf
Feature for bevy UI (#3546)
37f9e41 
# Objective

- For a plugin, I would like to enable `bevy_ui` without adding the complete `render` feature

## Solution

- Add a feature for `bevy_ui`


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Feature for bevy UI [Merged by Bors] - Feature for bevy UI Jan 4, 2022
@bors bors bot closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davier Davier Davier approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @cart @Davier @alice-i-cecile