Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add the license for the FiraMono font #3589

Closed
wants to merge 2 commits into from

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jan 8, 2022

I copied the license from https://github.com/mozilla/Fira/blob/master/LICENSE. The fact that the license file was missing came up in a discussion on discord.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 8, 2022
LICENSE Outdated
at your option.

FiraMono is licensed under the SIL Open Font License, Version 1.1 (assets/fonts/FiraMono-LICENSE)
Copy link
Member

@NiklasEi NiklasEi Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make something like a thirdparty license file instead of adding this in Bevy's License?
The new file could then be linked in the readme (or the examples readme).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or perhaps we can generalise this to be something to the effect of:
"Some asset files may be licensed under different terms where noted"

Copy link
Member

@mockersf mockersf Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets are not packaged with Bevy, but this license is (edit: maybe not actually, crates don't seem to specify the license file). I think Licenses for assets should be elsewhere.

There are some in https://github.com/bevyengine/bevy/blob/main/CREDITS.md or in https://github.com/bevyengine/bevy/blob/main/assets/models/AlienCake/README.md but those looks like attributions for CC0 licenses

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my own projects, I've been storing a .csv at the root of the assets folder that tracks licenses and attribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to CREDITS.md.

@james7132 james7132 added A-Meta About the project itself and removed S-Needs-Triage This issue needs to be labelled labels Jan 8, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 6, 2022
@bors bors bot changed the title Add the license for the FiraMono font [Merged by Bors] - Add the license for the FiraMono font May 6, 2022
@bors bors bot closed this May 6, 2022
@bjorn3 bjorn3 deleted the fira_mono_license branch May 7, 2022 19:21
robtfm pushed a commit to robtfm/bevy that referenced this pull request May 10, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta About the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants