Fix archetypes_generation being incorrectly updated for systems #383
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hey this also resolves #259 |
karroffel
added
C-Bug
BoxyUwU
changed the title
|
I've ran recently into that and this PR works for me. Good job! @cart could you take a look? |
|
Taking a look now! |
|
This makes sense to me. Nice catch! |
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue for this (#294) mentioned query systems not having this issue but it turns out they have the same issue, except instead of panicking they'll just run anyway and let you have multiple mutable borrows on the same components. This PR fixes it for both types of systems but it's probably worth investigating why one panics and the other is just UB.
resolves #294
resolves #259