UI component bundles derive clone #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge bevyengine/bevy -> ashneverdawn/bevy
Merge latest changes
|
To work around this, I have been using closures/functions for manipulating ahead of time then re-using for multiple nodes, but in many places, manipulating a local ahead of time then using |
|
Yup this is a nice usability win. Thanks! |
karroffel
added
C-Code-Quality
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
make Draw, TextStyle, and the rest of the ui components derive clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI component bundles and a few of their components weren't Clone, so when using
.with_children(|parent| {...})they had to be constructed directly within the closure. Now that they implement Clone, the data can be manipulated ahead of time and then moved into the closure with.clone()