Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast and correct one-shot systems with a system registry resource #4090

Closed
wants to merge 61 commits into from
Closed

Fast and correct one-shot systems with a system registry resource #4090

wants to merge 61 commits into from

Commits on Apr 18, 2022

  1. Basic functionality

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    3e6a8c5 View commit details
    Browse the repository at this point in the history

  2. commands.run_system

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f9b16c2 View commit details
    Browse the repository at this point in the history

  3. Add SystemRegistry resource as part of CorePlugin 

    No plugin exists for bevy_ecs, so this was the best place.
    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8e32c74 View commit details
    Browse the repository at this point in the history

  4. Run system by TypeId

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    961af58 View commit details
    Browse the repository at this point in the history

  5. Fix doc links

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d7ece72 View commit details
    Browse the repository at this point in the history

  6. run_system_by_type_id for World and Commands

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f54db1f View commit details
    Browse the repository at this point in the history

  7. Always flush commands from systems 

    Only the commands specific to this system are applied, so we should de-emphasize this choice.
    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    4fc35e5 View commit details
    Browse the repository at this point in the history

  8. Always initialize SystemRegistry on the World

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a9be933 View commit details
    Browse the repository at this point in the history

  9. Add test suite

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    fed175c View commit details
    Browse the repository at this point in the history

  10. Doc improvements

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    b883bca View commit details
    Browse the repository at this point in the history

  11. Store registered systems by their system labels

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ee33630 View commit details
    Browse the repository at this point in the history

  12. Ensure that run_system always runs the system exactly once

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    b520291 View commit details
    Browse the repository at this point in the history

  13. Advertise SystemRegistry in SystemState docs

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    7041713 View commit details
    Browse the repository at this point in the history

  14. Doc tests for SystemRegistry

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    1a5e308 View commit details
    Browse the repository at this point in the history

  15. Improve ergonomics of the register_system API

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    6f3a676 View commit details
    Browse the repository at this point in the history

  16. Improve run_by_label API ergonomics

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ebe2f29 View commit details
    Browse the repository at this point in the history

  17. Improve ergonomics of registering systems

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    3e41300 View commit details
    Browse the repository at this point in the history

  18. Note limitations

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    0f0a6dd View commit details
    Browse the repository at this point in the history

  19. Remove the need to manually update archetypes

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    870b12d View commit details
    Browse the repository at this point in the history

  20. Move SystemRegistry to a field on World

    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ba66966 View commit details
    Browse the repository at this point in the history

  21. Revert "Move SystemRegistry to a field on World" 

    This reverts commit ba66966.
    @alice-i-cecile
    alice-i-cecile committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5baac51 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Clippy fixes

    @alice-i-cecile
    alice-i-cecile committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    3be2a2e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into system_registry

    @alice-i-cecile
    alice-i-cecile committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4feb974 View commit details
    Browse the repository at this point in the history

  3. Clippy fix

    @alice-i-cecile
    alice-i-cecile committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4fe2937 View commit details
    Browse the repository at this point in the history

  4. System recursion should fail

    @alice-i-cecile
    alice-i-cecile committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    38fd422 View commit details
    Browse the repository at this point in the history

  5. Documentation improvements

    @alice-i-cecile
    alice-i-cecile committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    641f5df View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Nicer error handling

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    854a805 View commit details
    Browse the repository at this point in the history

  2. Return index from register system methods

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    7f41af9 View commit details
    Browse the repository at this point in the history

  3. Fix off by one error

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    5c35c51 View commit details
    Browse the repository at this point in the history

  4. Reduce noisy returns

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    681a6fc View commit details
    Browse the repository at this point in the history

  5. Fix broken tests

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    091e50f View commit details
    Browse the repository at this point in the history

  6. Add example

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    5f3925e View commit details
    Browse the repository at this point in the history

  7. Improve ergonomics of register_system method

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    e812bed View commit details
    Browse the repository at this point in the history

  8. Formatting

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    79aba5c View commit details
    Browse the repository at this point in the history

  9. Expose run_systems_by_boxed_label method

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    7c02da4 View commit details
    Browse the repository at this point in the history

  10. Create matching methods on App

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    cdd8cfc View commit details
    Browse the repository at this point in the history

  11. Polish example

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    e6094c6 View commit details
    Browse the repository at this point in the history

  12. Update examples README per CI

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    61db824 View commit details
    Browse the repository at this point in the history

  13. Simplify system_registry doc tests

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    afec804 View commit details
    Browse the repository at this point in the history

  14. Fix broken link 

    Co-authored-by: Federico Rinaldi <gisquerin@gmail.com>
    @alice-i-cecile @Nilirad
    alice-i-cecile and Nilirad committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    9423b49 View commit details
    Browse the repository at this point in the history

  15. Add Callback type to bevy_ecs itself

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    ebfca10 View commit details
    Browse the repository at this point in the history

  16. Implement PartialEq and Eq for Callback

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    1088dc6 View commit details
    Browse the repository at this point in the history

  17. Implement Hash for Callback

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    31b2277 View commit details
    Browse the repository at this point in the history

  18. Change run_system_by_boxed_label to run_callback

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    f505e2d View commit details
    Browse the repository at this point in the history

  19. Fix doc example

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    d451282 View commit details
    Browse the repository at this point in the history

  20. Manually implement Hash

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    89fa516 View commit details
    Browse the repository at this point in the history

  21. Fix doc example (for real?)

    @alice-i-cecile
    alice-i-cecile committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6cc0cb9 View commit details
    Browse the repository at this point in the history

  22. Avoid box allocation 

    Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
    @alice-i-cecile @MinerSebas
    alice-i-cecile and MinerSebas authored Jun 30, 2022
    Configuration menu
    Copy the full SHA
    5f29c93 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Mostly fix doc example

    @alice-i-cecile
    alice-i-cecile committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    707ec5d View commit details
    Browse the repository at this point in the history

  2. Remove frustrating doc example

    @alice-i-cecile
    alice-i-cecile committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    e7b6190 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Merge branch 'main' into system_registry

    @alice-i-cecile
    alice-i-cecile authored Jul 29, 2022
    Configuration menu
    Copy the full SHA
    0b46807 View commit details
    Browse the repository at this point in the history

  2. Typo fix 

    Co-authored-by: Aevyrie <aevyrie@gmail.com>
    @alice-i-cecile @aevyrie
    alice-i-cecile and aevyrie authored Jul 29, 2022
    Configuration menu
    Copy the full SHA
    ddfd7dc View commit details
    Browse the repository at this point in the history

  3. Clarify drawbacks of SystemState

    @alice-i-cecile
    alice-i-cecile authored Jul 29, 2022
    Configuration menu
    Copy the full SHA
    4d312e7 View commit details
    Browse the repository at this point in the history

  4. Punctuation 

    Co-authored-by: Federico Rinaldi <gisquerin@gmail.com>
    @alice-i-cecile @Nilirad
    alice-i-cecile and Nilirad authored Jul 29, 2022
    Configuration menu
    Copy the full SHA
    8cf91a4 View commit details
    Browse the repository at this point in the history

  5. Typo 

    Co-authored-by: Aevyrie <aevyrie@gmail.com>
    @alice-i-cecile @aevyrie
    alice-i-cecile and aevyrie authored Jul 29, 2022
    Configuration menu
    Copy the full SHA
    b2f5bf7 View commit details
    Browse the repository at this point in the history

  6. Fix mistake from merge conflict

    @alice-i-cecile
    alice-i-cecile committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    2254d4f View commit details
    Browse the repository at this point in the history

  7. Remove vague warning about callbacks

    @alice-i-cecile
    alice-i-cecile committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    25c66db View commit details
    Browse the repository at this point in the history

  8. Add Send and Sync bounds to label traits

    @alice-i-cecile
    alice-i-cecile committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    3ad29fd View commit details
    Browse the repository at this point in the history

  9. Clean up docs and naming around system registration

    @alice-i-cecile
    alice-i-cecile committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    ac1c2aa View commit details
    Browse the repository at this point in the history

  10. Make App and World APIs consistent

    @alice-i-cecile
    alice-i-cecile committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    e730525 View commit details
    Browse the repository at this point in the history

  11. Make doc links on higher level methods more useful

    @alice-i-cecile
    alice-i-cecile committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    55e61e1 View commit details
    Browse the repository at this point in the history