[Merged by Bors] - Slow down the many_cubes example #4117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
C-Examples
|
Much better! @DJMcNab does this fix it for you? |
alice-i-cecile
approved these changes
Mar 5, 2022
alice-i-cecile
added
A-Accessibility
DJMcNab
approved these changes
Mar 5, 2022
There was a problem hiding this comment.
This is definitely better, thanks.
Worth noting that these changes seem to double the fps, when it should only be removing ~19% of the cubes. At a guess, that's a memory pressure on my graphics card, but I thought I'd mention it to see if anyone else sees this.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
# Objective - After #4015, the `many_cubes` example could introduce discomfort in some cases ## Solution - Slow down the camera, add space between the cubes https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
bors
bot
changed the title
kurtkuehnert
pushed a commit
to kurtkuehnert/bevy
that referenced
this pull request
Mar 6, 2022
# Objective - After bevyengine#4015, the `many_cubes` example could introduce discomfort in some cases ## Solution - Slow down the camera, add space between the cubes https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - After bevyengine#4015, the `many_cubes` example could introduce discomfort in some cases ## Solution - Slow down the camera, add space between the cubes https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
many_cubesexample could introduce discomfort in some casesSolution
many_cubes.mp4