Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - export TaskPoolThreadAssignmentPolicy #4145

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - export TaskPoolThreadAssignmentPolicy #4145

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 8, 2022

Objective

Solution

  • TaskPoolThreadAssignmentPolicy was already public but not exported. Export it.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 8, 2022
@mockersf mockersf added A-Core Common functionality for all bevy apps C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Mar 8, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 8, 2022
@cart
Copy link
Member

cart commented Mar 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2022
@mockersf
export TaskPoolThreadAssignmentPolicy (#4145)
de2a47c 
# Objective

- Fix #2163
- Allow configuration of thread pools through `DefaultTaskPoolOptions`

## Solution

- `TaskPoolThreadAssignmentPolicy` was already public but not exported. Export it.
@bors
Copy link
Contributor

bors bot commented Mar 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title export TaskPoolThreadAssignmentPolicy [Merged by Bors] - export TaskPoolThreadAssignmentPolicy Mar 8, 2022
@bors bors bot closed this Mar 8, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
export TaskPoolThreadAssignmentPolicy (bevyengine#4145)
350ef1d 
# Objective

- Fix bevyengine#2163
- Allow configuration of thread pools through `DefaultTaskPoolOptions`

## Solution

- `TaskPoolThreadAssignmentPolicy` was already public but not exported. Export it.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
export TaskPoolThreadAssignmentPolicy (bevyengine#4145)
5db9eed 
# Objective

- Fix bevyengine#2163
- Allow configuration of thread pools through `DefaultTaskPoolOptions`

## Solution

- `TaskPoolThreadAssignmentPolicy` was already public but not exported. Export it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finer control over the DefaultTaskPoolOptions
3 participants
@mockersf @cart @alice-i-cecile