Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Tracy spans around main 3D passes #4182

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Tracy spans around main 3D passes #4182

wants to merge 4 commits into from

Conversation

superdump
Copy link
Contributor

Objective

  • Make visible how much time is spent building the Opaque3d, AlphaMask3d, and Transparent3d passes

Solution

  • Add a trace feature to bevy_core_pipeline
  • Add tracy spans around the three passes
  • I didn't do this for shadows, sprites, etc as they are only one pass in the node. Perhaps it should be split into 3 nodes to allow insertion of other nodes between...?

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 11, 2022
@superdump superdump added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times C-Testing A change that impacts how we test Bevy or how users test their apps A-Log and removed S-Needs-Triage This issue needs to be labelled labels Mar 11, 2022
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 11, 2022
@superdump superdump requested a review from cart March 13, 2022 18:04
@cart
Copy link
Member

cart commented Mar 19, 2022

One more tweak: can you adapt this to use the more ergonomic span syntax we just discovered?
#4246

@superdump
Copy link
Contributor Author

One more tweak: can you adapt this to use the more ergonomic span syntax we just discovered? #4246

Done.

@mockersf
Copy link
Member

Bors r+

bors bot pushed a commit that referenced this pull request Mar 19, 2022
@superdump
Tracy spans around main 3D passes (#4182)
fee7a26 
# Objective

- Make visible how much time is spent building the Opaque3d, AlphaMask3d, and Transparent3d passes

## Solution

- Add a `trace` feature to `bevy_core_pipeline`
- Add tracy spans around the three passes
- I didn't do this for shadows, sprites, etc as they are only one pass in the node. Perhaps it should be split into 3 nodes to allow insertion of other nodes between...?
@bors
Copy link
Contributor

bors bot commented Mar 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Tracy spans around main 3D passes [Merged by Bors] - Tracy spans around main 3D passes Mar 19, 2022
@bors bors bot closed this Mar 19, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@superdump @aevyrie
Tracy spans around main 3D passes (bevyengine#4182)
93a1778 
# Objective

- Make visible how much time is spent building the Opaque3d, AlphaMask3d, and Transparent3d passes

## Solution

- Add a `trace` feature to `bevy_core_pipeline`
- Add tracy spans around the three passes
- I didn't do this for shadows, sprites, etc as they are only one pass in the node. Perhaps it should be split into 3 nodes to allow insertion of other nodes between...?
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@superdump @ItsDoot
Tracy spans around main 3D passes (bevyengine#4182)
de7bfc8 
# Objective

- Make visible how much time is spent building the Opaque3d, AlphaMask3d, and Transparent3d passes

## Solution

- Add a `trace` feature to `bevy_core_pipeline`
- Add tracy spans around the three passes
- I didn't do this for shadows, sprites, etc as they are only one pass in the node. Perhaps it should be split into 3 nodes to allow insertion of other nodes between...?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@james7132 james7132 james7132 approved these changes

@cart cart Awaiting requested review from cart

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Performance A change motivated by improving speed, memory usage or compile times C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superdump @cart @mockersf @james7132