Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove outdated perf comments #4374

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove outdated perf comments #4374

wants to merge 1 commit into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Mar 31, 2022

Objective

Solution

  • Remove them

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 31, 2022
@mockersf mockersf added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Mar 31, 2022
@cart
Copy link
Member

cart commented Mar 31, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 31, 2022
@DJMcNab
Remove outdated perf comments (#4374)
aca7fc1 
# Objective

- The perf comments, added (by me) in #1349, became outdated once the initialisation call started to take an exclusive reference, (presumably in #1525).
- They have been naïvely transferred along ever since

## Solution

- Remove them
@bors
Copy link
Contributor

bors bot commented Mar 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove outdated perf comments [Merged by Bors] - Remove outdated perf comments Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@DJMcNab @aevyrie
Remove outdated perf comments (bevyengine#4374)
95875e6 
# Objective

- The perf comments, added (by me) in bevyengine#1349, became outdated once the initialisation call started to take an exclusive reference, (presumably in bevyengine#1525).
- They have been naïvely transferred along ever since

## Solution

- Remove them
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DJMcNab @ItsDoot
Remove outdated perf comments (bevyengine#4374)
930be03 
# Objective

- The perf comments, added (by me) in bevyengine#1349, became outdated once the initialisation call started to take an exclusive reference, (presumably in bevyengine#1525).
- They have been naïvely transferred along ever since

## Solution

- Remove them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJMcNab @cart @mockersf