Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - example on how to create an animation in code #4399

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - example on how to create an animation in code #4399

wants to merge 4 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Apr 3, 2022

Objective

  • Animation can be used outside of glTF, but are not obvious on how to create them

Solution

  • Add an example creating an animation

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 3, 2022
@mockersf mockersf added C-Examples An addition or correction to our examples A-Animation Make things move and change over time and removed S-Needs-Triage This issue needs to be labelled labels Apr 3, 2022
@mockersf
no need for .to_string()
5f23758 
Co-authored-by: devil ira <xytoluh@gmail.com>
alice-i-cecile
alice-i-cecile reviewed Apr 3, 2022
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile requested changes Apr 3, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some wording nits, once those are resolved this LGTM.

@alice-i-cecile alice-i-cecile added this to the Bevy 0.7 milestone Apr 3, 2022
@mockersf @alice-i-cecile
wording
5fc9b98 
Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>
@cart
Copy link
Member

cart commented Apr 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 7, 2022
@mockersf
example on how to create an animation in code (#4399)
3555603 
# Objective

- Animation can be used outside of glTF, but are not obvious on how to create them

## Solution

- Add an example creating an animation
@bors
Copy link
Contributor

bors bot commented Apr 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title example on how to create an animation in code [Merged by Bors] - example on how to create an animation in code Apr 8, 2022
@bors bors bot closed this Apr 8, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
example on how to create an animation in code (bevyengine#4399)
f1a6f4d 
# Objective

- Animation can be used outside of glTF, but are not obvious on how to create them

## Solution

- Add an example creating an animation
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
example on how to create an animation in code (bevyengine#4399)
df76029 
# Objective

- Animation can be used outside of glTF, but are not obvious on how to create them

## Solution

- Add an example creating an animation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Examples An addition or correction to our examples
Projects
None yet
Milestone
Bevy 0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @cart @alice-i-cecile @tim-blackbird