Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update touch.rs docs in bevy_input #4523

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Update touch.rs docs in bevy_input #4523

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2022

Objective

Solution

  • Document touch.rs inside of bevy_input.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 18, 2022
@ghost ghost added C-Docs An addition or correction to our documentation A-Input Player input via keyboard, mouse, gamepad, and more and removed S-Needs-Triage This issue needs to be labelled labels Apr 18, 2022
IceSentry
IceSentry approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, a couple of the comments almost feel auto generated, but I guess that it's to appease the deny(missing_docs) lint.

I left some comments, but none of them are blockers

alice-i-cecile
alice-i-cecile approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2022
Update touch.rs docs (#4523)
b3e39d0 
# Objective

- Part of the splitting process of #3692.

## Solution

- Document `touch.rs` inside of `bevy_input`.
@ghost ghost changed the title Update touch.rs docs Update touch.rs docs in bevy_input Apr 18, 2022
@bors
Copy link
Contributor

bors bot commented Apr 18, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update touch.rs docs in bevy_input [Merged by Bors] - Update touch.rs docs in bevy_input Apr 18, 2022
@bors bors bot closed this Apr 18, 2022
@ghost ghost deleted the update_touch_docs branch August 7, 2022 08:27
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ItsDoot
Update touch.rs docs (bevyengine#4523)
cd2be74 
# Objective

- Part of the splitting process of bevyengine#3692.

## Solution

- Document `touch.rs` inside of `bevy_input`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-i-cecile @IceSentry