Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Improve soundness of CommandQueue #4863

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Improve soundness of CommandQueue #4863

wants to merge 5 commits into from

Commits on May 28, 2022

  1. Use Vec<MaybeUninit<u8>> instead of Vec<u8> in CommandQueue

    @SkiFire13
    SkiFire13 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    d599e6b View commit details
    Browse the repository at this point in the history

  2. Use ManuallyDrop instead of std::mem::forget to not use command after… 

    … moving it
    @SkiFire13
    SkiFire13 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    9a11fbf View commit details
    Browse the repository at this point in the history

  3. Remove useless check for Vec::as_mut_ptr equals to null

    @SkiFire13
    SkiFire13 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    558c852 View commit details
    Browse the repository at this point in the history

  4. Add comment explaining why self.bytes.as_mut_ptr() is valid when only… 

    … ZSTs are written
    @SkiFire13
    SkiFire13 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    9cb3dc8 View commit details
    Browse the repository at this point in the history

  5. Add miri test for MaybeUninit<u8> vs u8 in CommandQueue

    @SkiFire13
    SkiFire13 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a9fdd9d View commit details
    Browse the repository at this point in the history