Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add benchmarks for schedule dependency resolution #4961

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions benches/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ glam = "0.20"
rand = "0.8"
rand_chacha = "0.3"
criterion = { version = "0.3", features = ["html_reports"] }
bevy_app = { path = "../crates/bevy_app" }
bevy_ecs = { path = "../crates/bevy_ecs" }
bevy_reflect = { path = "../crates/bevy_reflect" }
bevy_tasks = { path = "../crates/bevy_tasks" }
Expand Down Expand Up @@ -46,6 +47,11 @@ name = "world_get"
path = "benches/bevy_ecs/world_get.rs"
harness = false

[[bench]]
name = "schedule"
path = "benches/bevy_ecs/schedule.rs"
harness = false

[[bench]]
name = "reflect_list"
path = "benches/bevy_reflect/list.rs"
Expand Down
69 changes: 69 additions & 0 deletions benches/benches/bevy_ecs/schedule.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
use bevy_app::App;
use bevy_ecs::prelude::*;
use criterion::{criterion_group, criterion_main, Criterion};

criterion_group!(benches, build_schedule);
criterion_main!(benches);

fn build_schedule(criterion: &mut Criterion) {
// empty system
fn empty_system() {}

// Use multiple different kinds of label to ensure that dynamic dispatch
// doesn't somehow get optimized away.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, SystemLabel)]
struct NumLabel(usize);
JoJoJet marked this conversation as resolved.
Show resolved Hide resolved
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, SystemLabel)]
struct DummyLabel;

let mut group = criterion.benchmark_group("build_schedule");
group.warm_up_time(std::time::Duration::from_millis(500));
group.measurement_time(std::time::Duration::from_secs(15));

// Method: generate a set of `graph_size` systems which have a One True Ordering.
// Add system to the stage with full constraints. Hopefully this should be maximimally
// difficult for bevy to figure out.
let labels: Vec<_> = (0..1000).map(NumLabel).collect();

// Benchmark graphs of different sizes.
for graph_size in [100, 500, 1000] {
// Basic benchmark without constraints.
group.bench_function(format!("{graph_size}_schedule_noconstraints"), |bencher| {
bencher.iter(|| {
let mut app = App::new();
for _ in 0..graph_size {
app.add_system(empty_system);
}
app.update();
});
});

// Benchmark with constraints.
group.bench_function(format!("{graph_size}_schedule"), |bencher| {
bencher.iter(|| {
let mut app = App::new();
app.add_system(empty_system.label(DummyLabel));

// Build a fully-connected dependency graph describing the One True Ordering.
// Not particularly realistic but this can be refined later.
for i in 0..graph_size {
JoJoJet marked this conversation as resolved.
Show resolved Hide resolved
let mut sys = empty_system.label(labels[i]).before(DummyLabel);
for a in 0..i {
sys = sys.after(labels[a]);
}
for b in i + 1..graph_size {
sys = sys.before(labels[b]);
}
app.add_system(sys);
}
// Run the app for a single frame.
// This is necessary since dependency resolution does not occur until the game runs.
// FIXME: Running the game clutters up the benchmarks, so ideally we'd be
// able to benchmark the dependency resolution directly.
app.update();
});
});
}

group.finish();
}