Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create winit canvas under WebAssembly #506

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Create winit canvas under WebAssembly #506

merged 1 commit into from
Sep 19, 2020

Conversation

smokku
Copy link
Member

@smokku smokku commented Sep 17, 2020

With this change wasm32 build will actually create "window" canvas in browser and process input events on it.

Zrzut ekranu z 2020-09-17 22-11-53

@Moxinilian Moxinilian added C-Feature A new feature, making something new possible O-Web Specific to web (WASM) builds A-Windowing Platform-agnostic interface layer to run your app in labels Sep 17, 2020
examples/wasm/index.html Outdated Show resolved Hide resolved
@cart
Copy link
Member

cart commented Sep 18, 2020

Fantastic work as always! I think this is good to go as soon as the readme and index.html gets updated. Its probably not a problem yet, but as we start adding more bevy feature support, we might want to add a wasm feature that makes it easy to pull in the ones we currently support.

@smokku
Copy link
Member Author

smokku commented Sep 18, 2020

I guess current version should do it.

> cargo build --example winit_wasm --target wasm32-unknown-unknown --no-default-features
error: target `winit_wasm` in package `bevy` requires the features: `bevy_winit`
Consider enabling them by passing, e.g., `--features="bevy_winit"`

@cart
Copy link
Member

cart commented Sep 19, 2020

Sweetness. Lets merge it!

@cart cart merged commit 5e3731d into bevyengine:master Sep 19, 2020
@smokku smokku deleted the wasm branch September 19, 2020 14:17
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Feature A new feature, making something new possible O-Web Specific to web (WASM) builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants