-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - android - fix issues other than the rendering #5130
[Merged by Bors] - android - fix issues other than the rendering #5130
Conversation
Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>
Co-Authored-By: SarthakSingh31 <35749450+SarthakSingh31@users.noreply.github.com>
d4601b4
to
9fcab5e
Compare
Recorded on device: device-2022-06-29-134401.mp4Also works on emulator but it's much slower there |
bors try |
Tried running this and I'm getting a link error on my new Pixel 6:
|
Seems like I'm hitting this: katyo/oboe-rs#28 (comment) |
Ahh I didn't fully read the pr description. Ill try without audio features. Oops :) |
Disabling audio did fix the problem. But its pretty inconsistent about whether or not it will work. Sometimes it starts up just fine. Other times I get a black screen. |
Well... still an improvement 😄 Do you have anything in logs when it's a black screen? |
I've tried running the example on my Samsung S21+ and it occasionally works when I start the app, but I more often than not I get a black screen. The following message appears the adb logcat output and I assume is the crux of the problem:
|
Thanks for testing and reporting the issue! So it seems this PR doesn't fix that issue, it just happens less often. I would like to keep this PR free of rendering fix so that it doesn't become controversial... @cart would you agree on moving on with this PR as a first step to fix metadata, naming, and so on? I'll open more controversial PRs for the rest 😄 |
I'm in favor of merging this ASAP; it clearly improves matters, and Android is already broken so the user impact is 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of @alice-i-cecile's comment, I think this PR is good.
Yeah happy to iterate on this and these changes are good! |
bors r+ |
# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```
Build failed: |
bors r+ |
# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```
# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```
# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```
# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```
Objective
Solution
Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: