-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Rename headless_defaults
example to no_renderer
for clarity
#5263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jul 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer!
alice-i-cecile
added
A-Rendering
Drawing game state to the screen
C-Examples
An addition or correction to our examples
labels
Jul 9, 2022
Will fix CI in a bit |
LegNeato
force-pushed
the
headless_example_new
branch
from
July 10, 2022 00:56
2964855
to
9ef7e56
Compare
Shatur
approved these changes
Jul 10, 2022
DJMcNab
approved these changes
Jul 10, 2022
LoipesMas
approved these changes
Jul 10, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Jul 10, 2022
IceSentry
approved these changes
Jul 10, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
# Objective - Reduce confusion as the example opens a window and isn't truly "headless" - Fixes #5260. ## Solution - Rename the example and add to the docs that the window is expected.
bors
bot
changed the title
Rename
[Merged by Bors] - Rename Jul 11, 2022
headless_defaults
example to no_renderer
for clarityheadless_defaults
example to no_renderer
for clarity
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…engine#5263) # Objective - Reduce confusion as the example opens a window and isn't truly "headless" - Fixes bevyengine#5260. ## Solution - Rename the example and add to the docs that the window is expected.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…engine#5263) # Objective - Reduce confusion as the example opens a window and isn't truly "headless" - Fixes bevyengine#5260. ## Solution - Rename the example and add to the docs that the window is expected.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…engine#5263) # Objective - Reduce confusion as the example opens a window and isn't truly "headless" - Fixes bevyengine#5260. ## Solution - Rename the example and add to the docs that the window is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Examples
An addition or correction to our examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
headless_defaults
example displays an empty window #5260.Solution