-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement Debug
for Gamepads
#5291
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
A-Input
Player input via keyboard, mouse, gamepad, and more
labels
Jul 12, 2022
tim-blackbird
approved these changes
Jul 12, 2022
hymm
approved these changes
Jul 13, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Jul 13, 2022
IceSentry
approved these changes
Jul 13, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Generally a good idea. I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Generally a good idea. I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
bors
bot
changed the title
Implement
[Merged by Bors] - Implement Jul 13, 2022
Debug
for Gamepads
Debug
for Gamepads
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
Generally a good idea. I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
Generally a good idea. I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Generally a good idea. I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Input
Player input via keyboard, mouse, gamepad, and more
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally a good idea.
I ran into this because I wanted to store
Gamepads
in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168.This PR allows the
Debug
derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.