Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Don't panic when StandardMaterial normal_map hasn't loaded yet #5307

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Don't panic when StandardMaterial normal_map hasn't loaded yet #5307

wants to merge 2 commits into from

Commits on Jul 13, 2022

  1. Improve StandardMaterial normal_map error message 

    This unwrap() in pbr_material.rs will be hit if the normal_map image has not finished loading, resulting in an error message that is hard to debug. This PR improves the error message including a potential indication of why the unwrap() could have panic'd.
    @ChristopherBiscardi
    ChristopherBiscardi committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6785904 View commit details
    Browse the repository at this point in the history

  2. dont panic if texture isnt loaded yet

    @ChristopherBiscardi
    ChristopherBiscardi committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f311cbb View commit details
    Browse the repository at this point in the history