Replace many_for_each_mut
with iter_many_mut
.
#5313
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huh, that's wierd. How did I manage to close this with a force push. and why did the force push yeet everything...
:l
Objective
Replace
many_for_each_mut
withiter_many_mut
using the same tricks to avoid aliased mutability thatiter_combinations_mut
uses.Based on #5170.
View the changes for this PR here.
Why
many_for_each_mut
is worse for a few reasons:continue
,break
, andreturn
behaves like a limitedcontinue
.many_for_each_mut
as a mutable counterpart toiter_many
thaniter_many_mut
.iter_many_mut
API matches the existingiter_combinations_mut
API.