[Merged by Bors] - Export anyhow::error for custom asset loaders #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Assets
alice-i-cecile
approved these changes
Jul 17, 2022
mockersf
requested changes
Jul 18, 2022
There was a problem hiding this comment.
Could you also update the example to not depend on anyhow directly but use this reexport instead?
bevy/examples/asset/custom_asset.rs
Line 25 in 9c116d5
to
) -> BoxedFuture<'a, Result<(), bevy::asset::Error>> {I would prefer to not import the
Error struct directly, so either qualifying it as bevy::asset::Error or asset::Error
mockersf
approved these changes
Jul 20, 2022
mockersf
added
the
S-Ready-For-Final-Review
djeedai
approved these changes
Jul 20, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
If users try to implement a custom asset loader, they must manually import anyhow::error as it's used by the asset loader trait but not exported. https://github.com/bevyengine/bevy/blob/2b93ab58128178fef64de8134a130f036f07dc5d/examples/asset/custom_asset.rs#L25 Fixes #3138 Co-authored-by: sark <sarkahn@hotmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
If users try to implement a custom asset loader, they must manually import anyhow::error as it's used by the asset loader trait but not exported. https://github.com/bevyengine/bevy/blob/2b93ab58128178fef64de8134a130f036f07dc5d/examples/asset/custom_asset.rs#L25 Fixes bevyengine#3138 Co-authored-by: sark <sarkahn@hotmail.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
If users try to implement a custom asset loader, they must manually import anyhow::error as it's used by the asset loader trait but not exported. https://github.com/bevyengine/bevy/blob/2b93ab58128178fef64de8134a130f036f07dc5d/examples/asset/custom_asset.rs#L25 Fixes bevyengine#3138 Co-authored-by: sark <sarkahn@hotmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
If users try to implement a custom asset loader, they must manually import anyhow::error as it's used by the asset loader trait but not exported. https://github.com/bevyengine/bevy/blob/2b93ab58128178fef64de8134a130f036f07dc5d/examples/asset/custom_asset.rs#L25 Fixes bevyengine#3138 Co-authored-by: sark <sarkahn@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users try to implement a custom asset loader, they must manually import anyhow::error as it's used by the asset loader trait but not exported.
bevy/examples/asset/custom_asset.rs
Line 25 in 2b93ab5
Fixes #3138