Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Allows conversion of mutable queries to immutable queries #5376

Closed
wants to merge 4 commits into from

Conversation

harudagondi
Copy link
Member

Objective

Solution

  • Add to_readonly method on Query, which uses QueryState::as_readonly
  • AsRef is not feasible because creation of new queries is needed.

Changelog

Added

  • Allows conversion of mutable queries to immutable queries using Query::to_readonly.

@harudagondi harudagondi changed the title Query as ref Allows conversion of mutable queries to immutable queries Jul 19, 2022
crates/bevy_ecs/src/system/query.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible labels Jul 19, 2022
@alice-i-cecile alice-i-cecile self-requested a review July 19, 2022 13:41
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some better docs for you, but once those are in this LGTM! I love how easy this was to write.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 19, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 20, 2022
# Objective

- Allows conversion of mutable queries to immutable queries.
- Fixes #4606

## Solution

- Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly`
- `AsRef` is not feasible because creation of new queries is needed.

---

## Changelog

### Added

- Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
@bors bors bot changed the title Allows conversion of mutable queries to immutable queries [Merged by Bors] - Allows conversion of mutable queries to immutable queries Jul 20, 2022
@bors bors bot closed this Jul 20, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
…#5376)

# Objective

- Allows conversion of mutable queries to immutable queries.
- Fixes bevyengine#4606

## Solution

- Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly`
- `AsRef` is not feasible because creation of new queries is needed.

---

## Changelog

### Added

- Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…#5376)

# Objective

- Allows conversion of mutable queries to immutable queries.
- Fixes bevyengine#4606

## Solution

- Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly`
- `AsRef` is not feasible because creation of new queries is needed.

---

## Changelog

### Added

- Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…#5376)

# Objective

- Allows conversion of mutable queries to immutable queries.
- Fixes bevyengine#4606

## Solution

- Add `to_readonly` method on `Query`, which uses `QueryState::as_readonly`
- `AsRef` is not feasible because creation of new queries is needed.

---

## Changelog

### Added

- Allows conversion of mutable queries to immutable queries using `Query::to_readonly`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast query of mutable components to query of immutable
3 participants