Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize label comparisons and remove restrictions on types that can be labels #5377

Closed
wants to merge 22 commits into from
Closed

Optimize label comparisons and remove restrictions on types that can be labels #5377

wants to merge 22 commits into from

Commits on Aug 9, 2022

  1. store a number to distinguish labels of the same type

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    965fc36 View commit details
    Browse the repository at this point in the history

  2. use a fn pointer for formatting

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2769bd1 View commit details
    Browse the repository at this point in the history

  3. format generics in Label derive

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d514ecc View commit details
    Browse the repository at this point in the history

  4. allow more kinds of empty structs

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f57f166 View commit details
    Browse the repository at this point in the history

  5. use fn pointer for comparisons

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c3bbe81 View commit details
    Browse the repository at this point in the history

  6. add downcasting infrastructure

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b38c00c View commit details
    Browse the repository at this point in the history

  7. add an example for heap-allocated labels

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    dd70ae1 View commit details
    Browse the repository at this point in the history

  8. add a struct for interning labels

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    db9b93a View commit details
    Browse the repository at this point in the history

  9. support deriving interned labels

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    4699a23 View commit details
    Browse the repository at this point in the history

  10. improve derive example

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e76de87 View commit details
    Browse the repository at this point in the history

  11. hide downcast implementation details

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d27cf32 View commit details
    Browse the repository at this point in the history

  12. implement string labels

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a476189 View commit details
    Browse the repository at this point in the history

  13. add a type to intern concrete labels

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    08807e9 View commit details
    Browse the repository at this point in the history

  14. simplify intener APIs

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    81ecfa5 View commit details
    Browse the repository at this point in the history

  15. make the benchmark more realistic

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    45ec97b View commit details
    Browse the repository at this point in the history

  16. apply suggestions from code review

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    57f68dd View commit details
    Browse the repository at this point in the history

  17. undo an optimization 😭 

    MIRI is buggy so we can't use fn pointers for comparisons
    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    af4f557 View commit details
    Browse the repository at this point in the history

  18. use a reference to shrink the stack size

    @JoJoJet
    JoJoJet committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    07c7b1c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. fix a typo

    @JoJoJet
    JoJoJet committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    15c5046 View commit details
    Browse the repository at this point in the history

  2. use impl StageLabel for get_stage{_mut}

    @JoJoJet
    JoJoJet committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    0231141 View commit details
    Browse the repository at this point in the history

  3. hide vtable implementation details

    @JoJoJet
    JoJoJet committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    989b916 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. move interner types into bevy_utils

    @JoJoJet
    JoJoJet committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    224ffa9 View commit details
    Browse the repository at this point in the history