Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix bevy_reflect README #5477

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix bevy_reflect README #5477

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

  • Code in bevy_reflect README doesn't compile

Solution

  • Fix it

@mockersf mockersf added the A-Reflection Runtime information about types label Jul 28, 2022
@mockersf mockersf added this to the Bevy 0.8 milestone Jul 29, 2022
@mockersf
Copy link
Member Author

adding the 0.8 milestone to avoid publishing a crate with a bad README

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 29, 2022
@cart
Copy link
Member

cart commented Jul 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 29, 2022
@mockersf
fix bevy_reflect README (#5477)
4078273 
# Objective

- Code in `bevy_reflect` README doesn't compile

## Solution

- Fix it
@bors
Copy link
Contributor

bors bot commented Jul 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix bevy_reflect README [Merged by Bors] - fix bevy_reflect README Jul 29, 2022
@bors bors bot closed this Jul 29, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@mockersf @inodentry
fix bevy_reflect README (bevyengine#5477)
ae593fb 
# Objective

- Code in `bevy_reflect` README doesn't compile

## Solution

- Fix it
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
fix bevy_reflect README (bevyengine#5477)
c6c2b02 
# Objective

- Code in `bevy_reflect` README doesn't compile

## Solution

- Fix it
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
fix bevy_reflect README (bevyengine#5477)
4dab6df 
# Objective

- Code in `bevy_reflect` README doesn't compile

## Solution

- Fix it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @cart @alice-i-cecile @MrGVSV