Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Sync up bevy_sprite and bevy_ui shader View struct #5531

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Sync up bevy_sprite and bevy_ui shader View struct #5531

wants to merge 1 commit into from

Conversation

superdump
Copy link
Contributor

Objective

Solution

  • Sync shader View struct definition in bevy_sprite and bevy_ui with the correct definition that matches ViewUniform

@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Aug 1, 2022
@superdump superdump requested a review from cart August 1, 2022 16:16
@superdump
Copy link
Contributor Author

superdump commented Aug 1, 2022 •
edited
Loading

Longer-term, I think we should define a shader import for this in bevy_render and use it everywhere. But doing this for now as a minimal fix in case it were to be pulled into a 0.8.1. I don't think this one would be necessary but perhaps @cart would rather bundle the update.

@mockersf
Copy link
Member

mockersf commented Aug 1, 2022

couldn't they be imports?

@superdump
Copy link
Contributor Author

couldn't they be imports?

See above. :D

@superdump superdump mentioned this pull request Aug 1, 2022
Closed
@cart cart added this to the Bevy 0.8.1 milestone Aug 5, 2022
@cart
Copy link
Member

cart commented Aug 5, 2022

Yeah I think it makes sense to do this one first for 0.8.1

@cart
Copy link
Member

cart commented Aug 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 5, 2022
@superdump
Sync up bevy_sprite and bevy_ui shader View struct (#5531)
704d8e2 
# Objective

- Similar to #5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
@bors
Copy link
Contributor

bors bot commented Aug 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Sync up bevy_sprite and bevy_ui shader View struct [Merged by Bors] - Sync up bevy_sprite and bevy_ui shader View struct Aug 5, 2022
@bors bors bot closed this Aug 5, 2022
cart pushed a commit that referenced this pull request Aug 19, 2022
@superdump @cart
Sync up bevy_sprite and bevy_ui shader View struct (#5531)
b3ab4fc 
# Objective

- Similar to #5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
@superdump @maccesch
Sync up bevy_sprite and bevy_ui shader View struct (bevyengine#5531)
b414703 
# Objective

- Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@superdump @james7132
Sync up bevy_sprite and bevy_ui shader View struct (bevyengine#5531)
0f71c96 
# Objective

- Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@superdump @ItsDoot
Sync up bevy_sprite and bevy_ui shader View struct (bevyengine#5531)
0de20d5 
# Objective

- Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart Awaiting requested review from cart

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
Bevy 0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@superdump @mockersf @cart