Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fixes the types for Vec3 and Quat in scene example to remove WARN from the logs #5751

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fixes the types for Vec3 and Quat in scene example to remove WARN from the logs #5751

wants to merge 1 commit into from

Conversation

tkgalk
Copy link
Contributor

@tkgalk tkgalk commented Aug 20, 2022

Objective

Solution

  • Changes the Vec3 and Quat types.

@MrGVSV MrGVSV added C-Examples An addition or correction to our examples A-Scenes Serialized ECS data stored on the disk labels Aug 20, 2022
@Weibye Weibye added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 20, 2022
Carter0
Carter0 approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@Carter0 Carter0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cart
Copy link
Member

cart commented Aug 20, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 20, 2022
@tkgalk
fixes the types for Vec3 and Quat in scene example to remove WARN fro…
04538fd 
…m the logs (#5751)

# Objective
- Fixes #5745.

## Solution
- Changes the Vec3 and Quat types.
@bors
Copy link
Contributor

bors bot commented Aug 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fixes the types for Vec3 and Quat in scene example to remove WARN from the logs [Merged by Bors] - fixes the types for Vec3 and Quat in scene example to remove WARN from the logs Aug 20, 2022
@bors bors bot closed this Aug 20, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
@tkgalk @maccesch
fixes the types for Vec3 and Quat in scene example to remove WARN fro…
4d2d7ab 
…m the logs (bevyengine#5751)

# Objective
- Fixes bevyengine#5745.

## Solution
- Changes the Vec3 and Quat types.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@tkgalk @james7132
fixes the types for Vec3 and Quat in scene example to remove WARN fro…
c464f55 
…m the logs (bevyengine#5751)

# Objective
- Fixes bevyengine#5745.

## Solution
- Changes the Vec3 and Quat types.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tkgalk @ItsDoot
fixes the types for Vec3 and Quat in scene example to remove WARN fro…
a2f5bad 
…m the logs (bevyengine#5751)

# Objective
- Fixes bevyengine#5745.

## Solution
- Changes the Vec3 and Quat types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

@Carter0 Carter0 Carter0 approved these changes

@Weibye Weibye Weibye approved these changes

@afonsolage afonsolage afonsolage approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scenes Example isn't Recognizing Vec3 Type
6 participants
@tkgalk @cart @afonsolage @Weibye @Carter0 @MrGVSV