Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_pbr: Fix incorrect and unnecessary normal-mapping code #5766

Closed

Commits on Aug 22, 2022

  1. bevy_pbr: Remove incorrect and unnecessary normal-mapping code

    The FlightHelmet.gltf model's hose uses a double-sided material. Loading the
    model with a uniform scale of -1.0, and comparing against Blender, it was
    identified that negating the world-space tangent, bitangent, and interpolated
    normal produces incorrect lighting. Discussion with Morten Mikkelsen clarified
    that this is both incorrect and unnecessary.
    superdump committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8025c0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dbf9097 View commit details
    Browse the repository at this point in the history
  3. Minor shader fixes

    superdump committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0c04b2a View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Configuration menu
    Copy the full SHA
    009a501 View commit details
    Browse the repository at this point in the history