Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Helpers to check pipeline cache status #5796

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Helpers to check pipeline cache status #5796

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Aug 25, 2022 •
edited
Loading

Objective

  • In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so
  • Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done

Solution

  • Add a log with shaders being loaded and their shader defs
  • add a function on PipelineCache to return the number of ready pipelines

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Aug 25, 2022
djeedai
djeedai suggested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but public items need documentation.

crates/bevy_render/src/render_resource/pipeline_cache.rs Show resolved Hide resolved
djeedai
djeedai approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as #5600 does the documenting part already.

@djeedai djeedai added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 2, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 2, 2022
@mockersf
Helpers to check pipeline cache status (#5796)
480b3ba 
# Objective

- In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so
- Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done

## Solution

- Add a log with shaders being loaded and their shader defs
- add a function on `PipelineCache` to return the number of ready pipelines
@bors
Copy link
Contributor

bors bot commented Sep 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Helpers to check pipeline cache status [Merged by Bors] - Helpers to check pipeline cache status Sep 2, 2022
@bors bors bot closed this Sep 2, 2022
@rparrett rparrett mentioned this pull request Oct 25, 2022
Open
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
Helpers to check pipeline cache status (bevyengine#5796)
ee4ccc9 
# Objective

- In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so
- Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done

## Solution

- Add a log with shaders being loaded and their shader defs
- add a function on `PipelineCache` to return the number of ready pipelines
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Helpers to check pipeline cache status (bevyengine#5796)
db3b9cc 
# Objective

- In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so
- Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done

## Solution

- Add a log with shaders being loaded and their shader defs
- add a function on `PipelineCache` to return the number of ready pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weibye Weibye Weibye left review comments

@djeedai djeedai djeedai approved these changes

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mockersf @alice-i-cecile @cart @djeedai @Weibye