[Merged by Bors] - Remove Sync requirement in Decodable::Decoder
#5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weibye
added
A-Audio
12 tasks
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 29, 2022
# Objective - Allow non-`Sync` Decoders - Unblocks #5422. - Unblocks harudagondi/bevy_fundsp#1 ## Solution - Remove `Sync` requirement in `Decodable::Decoder` - This aligns with kira's [`Sound`] and majority of [oddio]'s types (like [`Mixer`]). [`Sound`]: https://docs.rs/kira/latest/kira/sound/trait.Sound.html [oddio]: https://docs.rs/oddio/latest/oddio/index.html [`Mixer`]: https://docs.rs/oddio/latest/oddio/struct.Mixer.html --- ## Changelog ### Changed - `Decodable::Decoder` now no longer requires `Sync` types.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sync requirement in Decodable::DecoderSync requirement in Decodable::Decoder
This was referenced Sep 1, 2022
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Allow non-`Sync` Decoders - Unblocks bevyengine#5422. - Unblocks harudagondi/bevy_fundsp#1 ## Solution - Remove `Sync` requirement in `Decodable::Decoder` - This aligns with kira's [`Sound`] and majority of [oddio]'s types (like [`Mixer`]). [`Sound`]: https://docs.rs/kira/latest/kira/sound/trait.Sound.html [oddio]: https://docs.rs/oddio/latest/oddio/index.html [`Mixer`]: https://docs.rs/oddio/latest/oddio/struct.Mixer.html --- ## Changelog ### Changed - `Decodable::Decoder` now no longer requires `Sync` types.
harudagondi
added a commit
to harudagondi/bevy_fundsp
that referenced
this pull request
Nov 14, 2022
# Objective - This is a very big refactor that allows better ergonomics, better refactorability, and better support for streaming audio. - Partially complete #1 for `bevy_audio`, - bevyengine/bevy#5819 ~needs to be merged first.~ is now merged! Now waiting for bevy 0.9. - NiklasEi/bevy_kira_audio#63 is blocking for `kira`. - Partially complete #2 for `oddio` - bevyengine/bevy#5828 needs to be resolved first - NiklasEi/bevy_kira_audio#63 is blocking for `kira` - `oddio` isn't even implemented yet for this PR - By virtue of solving #2, then #3 will be unblocked - Unblocks #4 by using `DspGraph` - Fixes #5 ## Solution - [x] Add support for - [x] `bevy_audio`, ~blocked by bevyengine/bevy#5819~ Now waiting for bevy 0.9. - [x] `bevy_kira_audio`, ~blocked by NiklasEi/bevy_kira_audio#72~ Now waiting for bevy 0.9. - [x] `bevy_oddio` - [ ] Add support for streaming audio in - [x] `bevy_audio`, ~blocked by bevyengine/bevy#5819~ - [ ] `bevy_kira_audio`, blocked by NiklasEi/bevy_kira_audio#63 - [x] `bevy_oddio` - [ ] Allow setting of parameters in - [ ] `bevy_audio`, blocked by bevyengine/bevy#5828 - [ ] `bevy_kira_audio`, blocked by NiklasEi/bevy_kira_audio#63 - [x] `bevy_oddio` ## Note for Users of this Branch If you are a user of `bevy_fundsp`, please try to test this PR! This currently only works with bevy_audio (EDIT: and bevy_oddio!), because this relies on a branch I made on bevy. --- ## Changelog Reworked the majority of the code. ## Added - A way to play streaming DSP sources. See `SourceType::Dynamic`. - You can play DSP sources using `Audio::play_dsp`. - Two iterators on streaming audio sources: `Iter` and `IterMono`. ### Changed - Adding the DSP plugin. - You must now call `DspPlugin::default()`. - The method on adding DSP sources. - No more initializing using `DspAssets`! - Just add your DSP function using `app.add_dsp_source` - Playing DSP sources require `Audio` to be mutable. (Use `ResMut`) - A lot of internals are shuffled around. ### Removed - `DspAssets` - `FnDspGraph` - `StreamingDspSource`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Allow non-`Sync` Decoders - Unblocks bevyengine#5422. - Unblocks harudagondi/bevy_fundsp#1 ## Solution - Remove `Sync` requirement in `Decodable::Decoder` - This aligns with kira's [`Sound`] and majority of [oddio]'s types (like [`Mixer`]). [`Sound`]: https://docs.rs/kira/latest/kira/sound/trait.Sound.html [oddio]: https://docs.rs/oddio/latest/oddio/index.html [`Mixer`]: https://docs.rs/oddio/latest/oddio/struct.Mixer.html --- ## Changelog ### Changed - `Decodable::Decoder` now no longer requires `Sync` types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
SyncDecodersSolution
Syncrequirement inDecodable::DecoderSoundand majority of oddio's types (likeMixer).Changelog
Changed
Decodable::Decodernow no longer requiresSynctypes.