Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump winit version and ndk-glue versions #5959

Closed
wants to merge 2 commits into from
Closed

Bump winit version and ndk-glue versions #5959

wants to merge 2 commits into from

Conversation

enfipy
Copy link
Contributor

@enfipy enfipy commented Sep 12, 2022

Objective

  • Android build currently fails as it has several ndk-glue versions.
  • Winit has released new versions.

Solution

  • Bump winit to latest version 0.27.3.
  • Bumo ndk-glue versions to 0.7.

@harudagondi
Copy link
Member

I think there is an earlier PR that bump winit and ndk-glue versions:

@enfipy
Copy link
Contributor Author

enfipy commented Sep 12, 2022 •
edited
Loading

@harudagondi, I see, missed that. Well, will be waiting till wgpu bumps its winit dep.

@enfipy enfipy closed this Sep 12, 2022
@harudagondi
Copy link
Member

I'm not really familiar with windowing in general. However, that PR is blocked by wgpu, according to the thread there. I think you should poke around in that PR and check the code.

@enfipy enfipy deleted the bump-winit-and-ndk-glue branch September 12, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enfipy @harudagondi