-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - remove copyless #6100
Closed
SpecificProtagonist
wants to merge
1
commit into
bevyengine:main
from
SpecificProtagonist:copylessless
Closed
[Merged by Bors] - remove copyless #6100
SpecificProtagonist
wants to merge
1
commit into
bevyengine:main
from
SpecificProtagonist:copylessless
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Sep 26, 2022
Nilirad
added
C-Dependencies
A change to the crates that Bevy depends on
C-Code-Quality
A section of code that is hard to understand or change
labels
Sep 26, 2022
tim-blackbird
approved these changes
Sep 26, 2022
afonsolage
approved these changes
Sep 26, 2022
it has also been removed from wgpu gfx-rs/wgpu#3050 which should remove it from Bevy dependency tree |
mockersf
approved these changes
Sep 26, 2022
mockersf
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Sep 26, 2022
Ooh thats great news. Much appreciated! |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
# Objective Remove copyless copyless apparently isn't needed anymore to prevent extraneous memcopies and therefore got deprecated: kvark/copyless#22
Pull request successfully merged into main. Build succeeded: |
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective Remove copyless copyless apparently isn't needed anymore to prevent extraneous memcopies and therefore got deprecated: kvark/copyless#22
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Remove copyless copyless apparently isn't needed anymore to prevent extraneous memcopies and therefore got deprecated: kvark/copyless#22
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Remove copyless copyless apparently isn't needed anymore to prevent extraneous memcopies and therefore got deprecated: kvark/copyless#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Code-Quality
A section of code that is hard to understand or change
C-Dependencies
A change to the crates that Bevy depends on
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remove copyless
copyless apparently isn't needed anymore to prevent extraneous memcopies and therefore got deprecated: kvark/copyless#22