[Merged by Bors] - Remove Transform::apply_non_uniform_scale
#6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Sep 30, 2022
mockersf
added
C-Usability
NathanSWard
added
the
M-Needs-Migration-Guide
IceSentry
approved these changes
Oct 5, 2022
rparrett
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
This is a holdover from back when `Transform` was backed by a private `Mat4` two years ago. Not particularly useful anymore :) ## Migration Guide `Transform::apply_non_uniform_scale` has been removed. It can be replaced with the following snippet: ```rust transform.scale *= scale_factor; ``` Co-authored-by: devil-ira <justthecooldude@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Transform::apply_non_uniform_scaleTransform::apply_non_uniform_scale
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
This is a holdover from back when `Transform` was backed by a private `Mat4` two years ago. Not particularly useful anymore :) ## Migration Guide `Transform::apply_non_uniform_scale` has been removed. It can be replaced with the following snippet: ```rust transform.scale *= scale_factor; ``` Co-authored-by: devil-ira <justthecooldude@gmail.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
This is a holdover from back when `Transform` was backed by a private `Mat4` two years ago. Not particularly useful anymore :) ## Migration Guide `Transform::apply_non_uniform_scale` has been removed. It can be replaced with the following snippet: ```rust transform.scale *= scale_factor; ``` Co-authored-by: devil-ira <justthecooldude@gmail.com>
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
This is a holdover from back when `Transform` was backed by a private `Mat4` two years ago. Not particularly useful anymore :) ## Migration Guide `Transform::apply_non_uniform_scale` has been removed. It can be replaced with the following snippet: ```rust transform.scale *= scale_factor; ``` Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
This is a holdover from back when `Transform` was backed by a private `Mat4` two years ago. Not particularly useful anymore :) ## Migration Guide `Transform::apply_non_uniform_scale` has been removed. It can be replaced with the following snippet: ```rust transform.scale *= scale_factor; ``` Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a holdover from back when
Transformwas backed by a privateMat4two years ago.Not particularly useful anymore :)
Migration Guide
Transform::apply_non_uniform_scalehas been removed.It can be replaced with the following snippet: