Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix end-of-animation index OOB #6210

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix end-of-animation index OOB #6210

wants to merge 1 commit into from

Conversation

thebluefish
Copy link
Contributor

Objective

Fixes #6204

Solution

Added another branch to handle end-of-animation special case

@thebluefish
Copy link
Contributor Author

So I'm actually unsure if this was the best way to write that line as the binary search could only ever return at most the final index - same with the Err(n) check.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Animation Make things move and change over time labels Oct 9, 2022
@alice-i-cecile
Copy link
Member

So I'm actually unsure if this was the best way to write that line as the binary search could only ever return at most the final index - same with the Err(n) check.

IMO it's better to code defensively; this behavior may change in the future, so we should be robust to being passed bad data here.

@mockersf
Copy link
Member

mockersf commented Oct 9, 2022

IMO it's better to code defensively

In this case it's defensive coding against Rust std...

Checking for equality could be faster

@alice-i-cecile
Copy link
Member

Could we use more robust error handling than indexing downstream too? I try to avoid it, precisely because it subtly panics.

alice-i-cecile
alice-i-cecile approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Oct 17, 2022
@thebluefish
Fix end-of-animation index OOB (#6210)
c6e0da4 
# Objective

Fixes #6204

## Solution

Added another branch to handle end-of-animation special case
@bors
Copy link
Contributor

bors bot commented Oct 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix end-of-animation index OOB [Merged by Bors] - Fix end-of-animation index OOB Oct 17, 2022
@bors bors bot closed this Oct 17, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@thebluefish @james7132
Fix end-of-animation index OOB (bevyengine#6210)
27788de 
# Objective

Fixes bevyengine#6204

## Solution

Added another branch to handle end-of-animation special case
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@thebluefish @james7132
Fix end-of-animation index OOB (bevyengine#6210)
ea4c871 
# Objective

Fixes bevyengine#6204

## Solution

Added another branch to handle end-of-animation special case
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@thebluefish @Pietrek14
Fix end-of-animation index OOB (bevyengine#6210)
b6e017b 
# Objective

Fixes bevyengine#6204

## Solution

Added another branch to handle end-of-animation special case
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@thebluefish @ItsDoot
Fix end-of-animation index OOB (bevyengine#6210)
8a6f907 
# Objective

Fixes bevyengine#6204

## Solution

Added another branch to handle end-of-animation special case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index out of bounds : for animation_player, irregular bug
3 participants
@thebluefish @alice-i-cecile @mockersf