Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - enum Visibility component #6320

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - enum Visibility component #6320

wants to merge 4 commits into from

Commits on Oct 20, 2022

  1. Turn the Visibility struct into an enum 

    add `Eq`, `PartialEq` derives to `Visibility`

impl `Copy` for `Visibility`

add a test ensuring that `Visibility` is one byte and that null pointer optimisation is doing its thing

Document the variants

clarify `Visibility::Inherited` behaviour for root-level entities

add unconditional `Visibility::Visible` variant

add tests

remove controversial `toggle` method since it may be confusing with 3
variants

impl `PartialEq` for `&Visibility`/`Visibility` pairs
    @ickk
    ickk committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9c24782 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. derive default enum variant

    @ickk
    ickk committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    84abd88 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Merge remote-tracking branch 'origin/main' into pr/ickk/6320

    @cart
    cart committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    cfd0272 View commit details
    Browse the repository at this point in the history

  2. fix test

    @cart
    cart committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    eca598a View commit details
    Browse the repository at this point in the history