[Merged by Bors] - Respect mipmap_filter when create ImageDescriptor with linear()/nearest() #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
MDeiml
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
I agree with these changes. Most of the time people will want linear mipmap filtering and I didn't find any indications that this should hurt performance in any way. (The nearest_descriptor change doesn't really matter since this is the default already, but I guess it's good to be explicit here.)
superdump
approved these changes
Nov 3, 2022
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
…st() (#6349) Respect mipmap_filter when create ImageDescriptor with linear()/nearest() # Objective Fixes #6348 ## Migration Guide This PR changes default `ImageSettings` and may lead to unexpected behaviour for existing projects with mipmapped textures. Users should provide custom `ImageSettings` resource with `mipmap_filter=FilterMode::Nearest` if they want to keep old behaviour. Co-authored-by: Yakov Borevich <j.borevich@gmail.com>
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
…st() (#6349) Respect mipmap_filter when create ImageDescriptor with linear()/nearest() # Objective Fixes #6348 ## Migration Guide This PR changes default `ImageSettings` and may lead to unexpected behaviour for existing projects with mipmapped textures. Users should provide custom `ImageSettings` resource with `mipmap_filter=FilterMode::Nearest` if they want to keep old behaviour. Co-authored-by: Yakov Borevich <j.borevich@gmail.com>
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…st() (bevyengine#6349) Respect mipmap_filter when create ImageDescriptor with linear()/nearest() # Objective Fixes bevyengine#6348 ## Migration Guide This PR changes default `ImageSettings` and may lead to unexpected behaviour for existing projects with mipmapped textures. Users should provide custom `ImageSettings` resource with `mipmap_filter=FilterMode::Nearest` if they want to keep old behaviour. Co-authored-by: Yakov Borevich <j.borevich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect mipmap_filter when create ImageDescriptor with linear()/nearest()
Objective
Fixes #6348
Migration Guide
This PR changes default
ImageSettingsand may lead to unexpected behaviour for existing projects with mipmapped textures. Users should provide customImageSettingsresource withmipmap_filter=FilterMode::Nearestif they want to keep old behaviour.