Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Expose rodio's Source and Sample traits in bevy_audio #6374

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Expose rodio's Source and Sample traits in bevy_audio #6374

wants to merge 2 commits into from

Conversation

elbertronnie
Copy link
Contributor

Objective

Solution

  • added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample.
  • rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.

@alice-i-cecile alice-i-cecile added A-Audio Sounds playback and modification C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Oct 26, 2022
@alice-i-cecile
Copy link
Member

@harudagondi for review.

@alice-i-cecile
Copy link
Member

@elbertronnie CI is failing as the file needs to be formatted :) I personally use format-on-save, but you can also use the cargo fmt --all command suggested in the failed CI job.

harudagondi
harudagondi approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@harudagondi harudagondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running cargo doc and checking the page looks good to me.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 27, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 27, 2022
@elbertronnie
Expose rodio's Source and Sample traits in bevy_audio (#6374)
0934abc 
# Objective

- Fixes #5876 .

## Solution

- added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample.
- rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.
@bors
Copy link
Contributor

bors bot commented Oct 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Expose rodio's Source and Sample traits in bevy_audio [Merged by Bors] - Expose rodio's Source and Sample traits in bevy_audio Oct 27, 2022
@bors bors bot closed this Oct 27, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@elbertronnie @james7132
Expose rodio's Source and Sample traits in bevy_audio (bevyengine#6374)
07fb9aa 
# Objective

- Fixes bevyengine#5876 .

## Solution

- added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample.
- rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@elbertronnie @ItsDoot
Expose rodio's Source and Sample traits in bevy_audio (bevyengine#6374)
c6fc468 
# Objective

- Fixes bevyengine#5876 .

## Solution

- added pub use statements to re-export the following traits in bevy_audio: rodio::source::Source, rodio::Sample, rodio::cpal::Sample.
- rodio::cpal::Sample was re-exported as CpalSample to avoid naming conflict with rodio::Sample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harudagondi harudagondi harudagondi approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Audio
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose rodio's Source and Sample trait in bevy_audio
4 participants
@elbertronnie @alice-i-cecile @harudagondi @mockersf