Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update glam 0.22, hexasphere 8.0, encase 0.4 #6427

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Update glam 0.22, hexasphere 8.0, encase 0.4 #6427

wants to merge 6 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 31, 2022 •
edited
Loading

Objective

  • Update glam to 0.22, hexasphere to 8.0, encase to 0.4

Solution

@james7132 james7132 added C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes A-Math Fundamental domain-agnostic mathematical operations labels Oct 31, 2022
@james7132 james7132 mentioned this pull request Oct 31, 2022
Closed
james7132
james7132 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval contingent on the updates to encase.

superdump
superdump approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also approved as long as the upstream deps also get updated.

@teoxoy
Copy link
Contributor

teoxoy commented Nov 6, 2022

Just released encase v0.4.

@mockersf mockersf added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Blocked This cannot move forward until something else changes labels Nov 6, 2022
This was referenced Nov 7, 2022
Closed
Closed
Closed
@mockersf mockersf changed the title Update glam 0.22 Update glam 0.22, hexasphere 8.0, encase 0.4 Nov 7, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 7, 2022
@mockersf
Update glam 0.22, hexasphere 8.0, encase 0.4 (#6427)
0aab699 
# Objective

- Update glam to 0.22, hexasphere to 8.0, encase to 0.4

## Solution

- Update glam to 0.22, hexasphere to 8.0, encase to 0.4
- ~~waiting on teoxoy/encase#17 and OptimisticPeach/hexasphere#13
@bors
Copy link
Contributor

bors bot commented Nov 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update glam 0.22, hexasphere 8.0, encase 0.4 [Merged by Bors] - Update glam 0.22, hexasphere 8.0, encase 0.4 Nov 7, 2022
@bors bors bot closed this Nov 7, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Update glam 0.22, hexasphere 8.0, encase 0.4 (bevyengine#6427)
44929b4 
# Objective

- Update glam to 0.22, hexasphere to 8.0, encase to 0.4

## Solution

- Update glam to 0.22, hexasphere to 8.0, encase to 0.4
- ~~waiting on teoxoy/encase#17 and OptimisticPeach/hexasphere#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@atlv24 atlv24 atlv24 approved these changes

@IceSentry IceSentry IceSentry approved these changes

@james7132 james7132 james7132 approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mockersf @teoxoy @alice-i-cecile @superdump @james7132 @IceSentry @atlv24 @tim-blackbird