Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Panic on dropping NonSend in non-origin thread. #6534

Closed
wants to merge 57 commits into from
Closed

[Merged by Bors] - Panic on dropping NonSend in non-origin thread. #6534

wants to merge 57 commits into from

Commits on Nov 10, 2022

  1. Abort on dropping NonSend in non-origin thread.

    @james7132
    james7132 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    bbb7e85 View commit details
    Browse the repository at this point in the history

  2. Fix safety comments

    @james7132
    james7132 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0f4b73d View commit details
    Browse the repository at this point in the history

  3. Invert is_send

    @james7132
    james7132 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e83e8e3 View commit details
    Browse the repository at this point in the history

  4. Factor out drop-abort

    @james7132
    james7132 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e46ec0c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Fix access, replace MainThreadValidator

    @james7132
    james7132 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    0898a54 View commit details
    Browse the repository at this point in the history

  2. Update docs

    @james7132
    james7132 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e4d61c1 View commit details
    Browse the repository at this point in the history

  3. Switch to always panic, use ManuallyDrop

    @james7132
    james7132 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    944b83c View commit details
    Browse the repository at this point in the history

  4. Formatting

    @james7132
    james7132 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    9b712df View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 authored Dec 1, 2022
    Configuration menu
    Copy the full SHA
    776ffaf View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Split out into NonSendResources

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ba27136 View commit details
    Browse the repository at this point in the history

  2. Cleanup docs and type definitions

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    c3708d4 View commit details
    Browse the repository at this point in the history

  3. Fix CI

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    16ae491 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    cc4c611 View commit details
    Browse the repository at this point in the history

  5. Update safety docs.

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1a09486 View commit details
    Browse the repository at this point in the history

  6. Actually fix CI

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f935aa2 View commit details
    Browse the repository at this point in the history

  7. Small cleanup

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f4281e6 View commit details
    Browse the repository at this point in the history

  8. Fix WorldCell's use of NonSend

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1692da8 View commit details
    Browse the repository at this point in the history

  9. Fix bevy_window

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2b11ea3 View commit details
    Browse the repository at this point in the history

  10. Use const generics to split on Send/!Send

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    638e95c View commit details
    Browse the repository at this point in the history

  11. Use const generics instead of duplicating code

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    c37f26e View commit details
    Browse the repository at this point in the history

  12. Use the right branch

    @james7132
    james7132 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ee5de65 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Add panic sections to World's API docs

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d195cb6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @james7132 @BoxyUwU
    james7132 and BoxyUwU authored Dec 3, 2022
    Configuration menu
    Copy the full SHA
    93334a0 View commit details
    Browse the repository at this point in the history

  3. Remove non_send_scope

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8f72292 View commit details
    Browse the repository at this point in the history

  4. Split insert_non_send_by_id from insert_resource_by_id

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b3fffd9 View commit details
    Browse the repository at this point in the history

  5. Fix safety comment and tests

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    54e5a50 View commit details
    Browse the repository at this point in the history

  6. Exhaustively decompose Storages in check_change_ticks

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    5f6e91b View commit details
    Browse the repository at this point in the history

  7. Remove spurious is_send in docs

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    cfb8173 View commit details
    Browse the repository at this point in the history

  8. Update safety docs on initialize_resource_internal

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    5900696 View commit details
    Browse the repository at this point in the history

  9. Check that Send resources have correct metadata on initialization

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    95e575f View commit details
    Browse the repository at this point in the history

  10. Formatting

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2bff28c View commit details
    Browse the repository at this point in the history

  11. Undo changes to BlobVec, how the hell did this get in here

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6af4c4e View commit details
    Browse the repository at this point in the history

  12. Fix docs link

    @james7132
    james7132 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    e056626 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @james7132 @BoxyUwU
    james7132 and BoxyUwU authored Dec 4, 2022
    Configuration menu
    Copy the full SHA
    58bcb66 View commit details
    Browse the repository at this point in the history

  2. Stronger assert

    @james7132
    james7132 committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    9db8041 View commit details
    Browse the repository at this point in the history

  3. Fix CI

    @james7132
    james7132 committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    d713d84 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @james7132 @BoxyUwU
    james7132 and BoxyUwU authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    314a86e View commit details
    Browse the repository at this point in the history

  2. Small cleanup

    @james7132
    james7132 committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    e06677a View commit details
    Browse the repository at this point in the history

  3. Update crates/bevy_ecs/src/world/mod.rs 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @james7132 @BoxyUwU
    james7132 and BoxyUwU authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    de05d57 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    b4d6303 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Merge branch 'abort-on-nonsend-drop' of github.com:james7132/bevy int… 

    …o abort-on-nonsend-drop
    @james7132
    james7132 committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    a9895c0 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @james7132 @BoxyUwU
    james7132 and BoxyUwU authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    db4c6d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7578306 View commit details
    Browse the repository at this point in the history

  3. Move std::thread::panicking check to Drop impl

    @james7132
    james7132 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5e182fc View commit details
    Browse the repository at this point in the history

  4. Update safety comment about validate_access in Drop

    @james7132
    james7132 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    263ed85 View commit details
    Browse the repository at this point in the history

  5. Add the missing get_non_send_by_id APIs

    @james7132
    james7132 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e4a0a9a View commit details
    Browse the repository at this point in the history

  6. Formatting

    @james7132
    james7132 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5be8450 View commit details
    Browse the repository at this point in the history

  7. Add test for distinct storage and missing panic comments

    @james7132
    james7132 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    587ea78 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Make the safety comments on _by_id APIs more accurate

    @james7132
    james7132 committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    68de55f View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Reword panic docs. 

    Co-authored-by: Boxy <supbscripter@gmail.com>
    @james7132 @BoxyUwU
    james7132 and BoxyUwU authored Dec 12, 2022
    Configuration menu
    Copy the full SHA
    4e8412f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 authored Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ebe33dd View commit details
    Browse the repository at this point in the history

  3. Fix CI

    @james7132
    james7132 committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    87c88ab View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    6d39cd5 View commit details
    Browse the repository at this point in the history

  2. Revert changes with NonSendMarker

    @james7132
    james7132 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    8b8a735 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    6c8e988 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @james7132
    james7132 committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    2c5be6d View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge branch 'main' into abort-on-nonsend-drop

    @james7132
    james7132 committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    b236f9d View commit details
    Browse the repository at this point in the history